Adam's Lair Forum

game development and casual madness
It is currently 2017/11/19, 14:19

All times are UTC + 1 hour [ DST ]




Post new topic Reply to topic  [ 8 posts ] 
Author Message
PostPosted: 2015/12/14, 18:33 
Newbie
Newbie

Joined: 2015/11/08, 13:29
Posts: 8
Role: Professional
Attention Soundies

I've just finished the first draft of a new Duality audio file importer plugin. As you may know, Duality is currently limited to loading OGG Vorbis audio files. This project aims to extend the number of audio formats supported by implementing an editor plugin which fits into Duality's normal asset importing workflow.

Image

Simply drag your audio files into Duality's Project View window.

(big files may appear to stall the program - there's no progress bar yet - just pretend there is a progress bar)


Formats Supported

.aiff (including files with extensions: .aif, .aifc)
.mp2
.mp3
.flac
.wav

More formats may be supported in the future.


Installation

Image

ExtendedAudioImporter can be installed via Duality Editor's built in package manager.
* Change the package view to "Online Repository"
* Search for "Extended Audio Importer"
* Press the "Install" button

For more info, visit the project page: https://github.com/importjingles/ExtendedAudioImporter

...or just reply here :)

[EDIT 15th Dec 2015 - Removing the word Duality from the name and updating the install information]


Last edited by importjingles on 2015/12/15, 12:33, edited 2 times in total.

Top
 Profile  
 
PostPosted: 2015/12/14, 20:57 
Forum Addict
Forum Addict
User avatar

Joined: 2013/09/19, 14:31
Posts: 852
Location: Italy
Role: Hobbyist
Wow, that's one hell of a first impression :mrgreen:
looking forward to testing it out. Looks well done and properly executed!

Oh, and welcome to the forum ^^

_________________
Come on Duality's Discord channel. It's entertaining and productive! :mrgreen:


Top
 Profile  
 
PostPosted: 2015/12/14, 21:59 
Newbie
Newbie

Joined: 2015/11/08, 13:29
Posts: 8
Role: Professional
Hey thanks! :) That's good to hear.

Any feedback would be most welcome.

Things I'm unsure about are:
* Sensible way to report exceptions back to Duality. Currently I'm just letting them fly (I haven't read the Duality importer code much yet).
* Whether it can be released under MIT license (considering libsox is LGPL).


Top
 Profile  
 
PostPosted: 2015/12/15, 04:10 
Forum Adept
Forum Adept

Joined: 2014/12/13, 00:11
Posts: 398
Location: Brazil
Role: Gamer
Welcome to the forums!

I haven't used the plugin yet, but here's a feedback (more of a personal opinion than an actual feedback): IMO the plugin should be named "Extended Audio Importer/Handler" instead of prefixing it with "Duality". It's a bit redundant :P.

Regarding the license, here's an answer that might be what you're looking for.

I'll look forward to use this plugin in my future projects!

_________________
I only know the basics of C#. I have no advanced knowledge.


Top
 Profile  
 
PostPosted: 2015/12/15, 12:03 
Newbie
Newbie

Joined: 2015/11/08, 13:29
Posts: 8
Role: Professional
The name change makes sense, I'll fix that up. I wasn't sure how packages were identified so I prepended the word Duality everywhere, but I can see now it wasn't necessary.

Thanks for the google search on the license. Legal stuff makes my head swim.

[EDIT 15th Dec 2015 - Package name has now been updated on GitHub and NuGet]


Top
 Profile  
 
PostPosted: 2015/12/16, 14:39 
Site Admin
Site Admin
User avatar

Joined: 2013/05/11, 22:30
Posts: 2028
Location: Germany
Role: Professional
Said it on GitHub, I'll say it again here: Didn't get around to test it yet, but this looks really good. Keep it up! I'm sure this will come in handy for a lot of users. :)

importjingles wrote:
Things I'm unsure about are:
* Sensible way to report exceptions back to Duality. Currently I'm just letting them fly (I haven't read the Duality importer code much yet).


In general, if your code crashes in an unexpected way, Duality will try to catch it and report back to the users, which will then come complaining to you, so you can fix the underlying problem. :mrgreen:

If your code fails in an expected way, you should generally try to fail gracefully, but importers are a special case: Duality actually watches each of them closely and handles their exceptions as an expected failure case, which is logged and later reported to the user. So you can actually throw an Exception there and it will be fine. If you expect something bad to happen at some point out of your control, it's still a good thing to detect it first and do something about it yourself though. Prefer failing explicitly.

importjingles wrote:
Whether it can be released under MIT license (considering libsox is LGPL).


I think, as long as you're only using its binaries, but do not include any of its source code, this should be fine - but this legal stuff really isn't my specialty either. RockyTV's link looks quite good and seems to have a similar gist.



Moving this to "Projects".

_________________
Blog | GitHub | Twitter (@Adams_Lair)


Top
 Profile  
 
PostPosted: 2015/12/16, 15:32 
Newbie
Newbie

Joined: 2015/11/08, 13:29
Posts: 8
Role: Professional
Thanks, Adam, I saw your GitHub comment. It's really encouraging to get that kind of feedback. This plugin won't be my only contribution :)

Quote:
If your code fails in an expected way, you should generally try to fail gracefully, but importers are a special case

Groovy. Having read that, I think exceptions are fine in this case, and I'll try to make the exception info a bit more informative. There are a couple other code design related things I wanted to talk about elsewhere. Perhaps I can grab you for a chat in the new year after this christmas madness?

To everyone else: If I've missed your favourite audio file format, and it's common enough, then give me a shout via GitHub and we can decide how much work it would be to implement it. Some may be easier than others.

Have fun making game audio!


Top
 Profile  
 
PostPosted: 2015/12/16, 16:42 
Site Admin
Site Admin
User avatar

Joined: 2013/05/11, 22:30
Posts: 2028
Location: Germany
Role: Professional
importjingles wrote:
There are a couple other code design related things I wanted to talk about elsewhere. Perhaps I can grab you for a chat in the new year after this christmas madness?


Sure, we can set something up. Just remind me with a forum PM next year, I have a bit of real life stuff going on and might forget otherwise.

_________________
Blog | GitHub | Twitter (@Adams_Lair)


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 8 posts ] 

All times are UTC + 1 hour [ DST ]


Who is online

Users browsing this forum: No registered users and 3 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum

Jump to:  
Powered by phpBB® Forum Software © phpBB Group